Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common.skip annotation for sap-skiplocation query option #82

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

HeikoTheissen
Copy link
Contributor

@HeikoTheissen HeikoTheissen commented Jan 19, 2021

The query options sap-skiplocation=<entity URI>&sap-skipcontext=<n> instruct the server to return an entity collection with the number of entries specified by $top, with a $skip value chosen by the server such that the entity whose URI is given in sap-skiplocation is visible, preferably with <n> entities before it.

@HeikoTheissen HeikoTheissen marked this pull request as draft January 19, 2021 15:38
@HeikoTheissen HeikoTheissen marked this pull request as ready for review September 30, 2022 09:27
@HeikoTheissen HeikoTheissen changed the title Common.skip annotation for sap-skipfilter query option Common.skip annotation for sap-skiplocation query option Sep 30, 2022
@@ -29,86 +29,87 @@ Term|Type|Description
[SecondaryKey](./Common.xml#L206:~:text=<Term%20Name="-,SecondaryKey,-") *(Deprecated)*|\[PropertyPath\]|<a name="SecondaryKey"></a>Use term `AlternateKeys` from the OASIS Core vocabulary instead
[MinOccurs](./Common.xml#L218:~:text=<Term%20Name="-,MinOccurs,-")|Int64|<a name="MinOccurs"></a>The annotated set or collection contains at least this number of items
[MaxOccurs](./Common.xml#L222:~:text=<Term%20Name="-,MaxOccurs,-")|Int64|<a name="MaxOccurs"></a>The annotated set or collection contains at most this number of items
[AssociationEntity](./Common.xml#L226:~:text=<Term%20Name="-,AssociationEntity,-")|\[NavigationPropertyPath\]|<a name="AssociationEntity"></a>Entity representing an n:m association with attributes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Common.md file is derived from one of the others? Which one is the original? (Because this diff is too large, I would like to just review your manual changes)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Common.xml is the original.

@@ -223,6 +223,14 @@
<Annotation Term="Core.Description" String="The annotated set or collection contains at most this number of items" />
</Term>

<Term Name="skip" Type="Edm.Int64" AppliesTo="Collection">
<Annotation Term="Core.IsInstanceAnnotation"/>
<Annotation Term="Core.Description" String="The server assumed this value for $skip when it determined the annotated collection"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like the annotation would even be expected if $skip was explicitly given? Or does "assume" intend to rule this out?

P.S.: "The query option sap-skiplocation=[,] instructs the server to return an entity collection with the number of entries specified by $top, with a $skip value chosen by the server such that the entity whose URI is given in sap-skiplocation is visible, preferably with entities before it." --> where will this be documented? I like it!

Copy link
Contributor Author

@HeikoTheissen HeikoTheissen Sep 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. If the request contains a $skip, the server need not assume a value.
Regarding, sap-skiplocation, see here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants